Skip to content

doc: comment on spark history integration #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 22, 2025

Description

Failed attempts to implement this in the branch: feat/connect-history-284

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Apr 22, 2025
@razvan razvan requested a review from a team April 22, 2025 11:38
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Apr 22, 2025
sbernauer
sbernauer previously approved these changes Apr 22, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there some sort of link to e.g. Github issue at Spark that we give the user?

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 22, 2025
@razvan
Copy link
Member Author

razvan commented Apr 22, 2025

Thanks! Is there some sort of link to e.g. Github issue at Spark that we give the user?

I couldn't find anything

@razvan razvan requested a review from sbernauer April 22, 2025 12:47
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

@razvan razvan enabled auto-merge April 22, 2025 12:50
@razvan razvan added this pull request to the merge queue Apr 22, 2025
Merged via the queue into main with commit ab4cf70 Apr 22, 2025
17 checks passed
@razvan razvan deleted the docs/connect-history branch April 22, 2025 13:06
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 22, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Apr 23, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants