Skip to content

💥 Checks should be able to fail in release scripts (remove set +e) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #694
NickLarsenNZ opened this issue Apr 24, 2025 · 0 comments · May be fixed by #105
Open
Tracked by #694

💥 Checks should be able to fail in release scripts (remove set +e) #103

NickLarsenNZ opened this issue Apr 24, 2025 · 0 comments · May be fixed by #105
Labels
release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0

Comments

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Apr 24, 2025 •
edited
Loading

Note

This came out of the 25.3.0 Release Retro.

Currently, failures are ignored during checks.

Examples

stackable-utils/release/create-release-candidate-branch.sh

Lines 346 to 350 in f4ffbb5

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
checks
set -e

stackable-utils/release/post-release.sh

Lines 211 to 215 in f4ffbb5

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
check_operators
set -e

stackable-utils/release/post-release.sh

Lines 203 to 205 in 374f25d

set +e
check_products
set -e

stackable-utils/release/tag-release-candidate.sh

Lines 212 to 216 in f4ffbb5

# sanity checks before we start: folder, branches etc.
# deactivate -e so that piped commands can be used
set +e
checks
set -e

@NickLarsenNZ NickLarsenNZ added the release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0 label Apr 24, 2025
@NickLarsenNZ NickLarsenNZ mentioned this issue Apr 24, 2025
Open
29 tasks
@NickLarsenNZ NickLarsenNZ changed the title 💥 Checks should fail in release scripts (remove set +e) 💥 Checks should be able to fail in release scripts (remove set +e) Apr 24, 2025
@NickLarsenNZ NickLarsenNZ linked a pull request May 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(release): Make scripts exit on failure stackabletech/stackable-utils
1 participant
@NickLarsenNZ