fix(release): Make scripts exit on failure #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they were originally there to handle failures without exiting then that should be done through regular means without disabling the flag.
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
adwk67
reviewed
May 5, 2025
| @@ -344,10 +344,7 @@ main() { | |||
| check_dependencies | |||
|
|
|||
| # sanity checks before we start: folder, branches etc. | |||
| # deactivate -e so that piped commands can be used | |||
| set +e | |||
There was a problem hiding this comment.
This short-circuits without logging out helpful information. e.g. running this in main
./release/create-release-candidate-branch.sh -t 25.7.0-rc1 -w products
shows:
Expected release branch is missing: release-25.7
which is suppressed with this PR change, so I am not sure this is an improvement.
There was a problem hiding this comment.
Although we certainly exit more consistently now, albeit with sometimes less info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
If they were originally there to handle failures without exiting then that should be done through regular means without disabling the flag.