Skip to content

fix: olm script updates for 25.3 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix: olm script updates for 25.3 #102

merged 3 commits into from
Apr 15, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 8, 2025

Part of stackabletech/issues#714

  • Use operator-sdk to validate bundles only. Previously it was used to generate bundle skeletons too which is not necessary and causes more troubles than it helps.
  • Bundles are generated in /tmp to avoid polluting the local dir.
  • Used in the linked issue above.

@razvan razvan self-assigned this Apr 8, 2025
@razvan razvan marked this pull request as ready for review April 15, 2025 10:26
@razvan razvan requested a review from a team April 15, 2025 13:29
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Apr 15, 2025
@razvan razvan enabled auto-merge April 15, 2025 13:30
adwk67
adwk67 previously approved these changes Apr 15, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test anything, but LGTM and I assume it was tested more than enough in the latest certification round :) (maybe a line or two in the README to summarize what has been changed here and why? But I'll leave that up to you)

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 15, 2025
@razvan
Copy link
Member Author

razvan commented Apr 15, 2025

Didn't test anything, but LGTM and I assume it was tested more than enough in the latest certification round :) (maybe a line or two in the README to summarize what has been changed here and why? But I'll leave that up to you)

Yes it was used extensively already :)

The readme is already kind of overloaded IMO.

A changelog would be more appropriate, but we don't make releases here.

@razvan razvan added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit f4ffbb5 Apr 15, 2025
1 check passed
@razvan razvan deleted the fix/ocp-cert-25.3 branch April 15, 2025 15:06
@razvan
Copy link
Member Author

razvan commented Apr 15, 2025

Thank you!

@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 28, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants