Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

[Merged by Bors] - Bump clap to 4.0 #150

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Bump clap to 4.0 #150

wants to merge 5 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 20, 2022

Description

Normal functionality as well as auto-completion tested successfully.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from a team October 20, 2022 13:56
@sbernauer sbernauer changed the title Bump to clap 4.0 Bump clap to 4.0 Oct 20, 2022
@fhennig fhennig self-assigned this Oct 24, 2022
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes that have been made look good so far. There are a lot of deprecation warnings though that I think would be good to fix already. Run

cargo check --features clap/deprecated

To see what needs fixing. Obviously not all of these are necessary to fix now, but I think we can go for the low-haning fruit at least

Also, the changelog suggests to include unit tests using debug_assert:

#[derive(clap::Parser)]
struct Cli {
    ...
}

#[test]
fn verify_cli() {
    use clap::CommandFactory;
    Cli::command().debug_assert()
}

@sbernauer
Copy link
Member Author

many thx, feedback adressed

@sbernauer sbernauer requested a review from fhennig October 24, 2022 10:24
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 25, 2022
## Description

Normal functionality as well as auto-completion tested successfully.
@bors
Copy link

bors bot commented Oct 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Bump clap to 4.0 [Merged by Bors] - Bump clap to 4.0 Oct 25, 2022
@bors bors bot closed this Oct 25, 2022
@bors bors bot deleted the clap-4 branch October 25, 2022 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants