Skip to content

Grant the privileges required for graceful shutdowns to the admin user in the OPA rego rules #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Apr 19, 2024

Description

Grant the privileges required for graceful shutdowns to the admin user in the OPA rego rules

Required for #574

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber self-assigned this Apr 19, 2024
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Apr 19, 2024

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea and change LGTM. However, I would prefer if we don't slam just every permission on the admin user, but would only add the need permissions, rw on system_information in this case. I know this might make the rules a bit more complicated...

I would be even happier if we would use meanifung names, so not admin but graceful-shutdown for graceful shutdown. But I need to check what happens on TrinoClusters without OPA (will they get a 403?)

@siegfriedweber siegfriedweber changed the title Grant all privileges to the admin user in the OPA rego rules Grant the privileges required for graceful shutdowns to the admin user in the OPA rego rules Apr 22, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@sbernauer
Copy link
Member

FYI, I'm copying the new rule to the end-to-end-security demo. I hope they will not be changed before merging

sbernauer added a commit to stackabletech/demos that referenced this pull request Apr 23, 2024
@siegfriedweber siegfriedweber added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 0a1545f Apr 23, 2024
30 checks passed
@siegfriedweber siegfriedweber deleted the stackable-opa-policies branch April 23, 2024 14:34
github-merge-queue bot pushed a commit to stackabletech/demos that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants