Skip to content

Remove repo_name for gazelle and rules_go #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

am19
Copy link

@am19 am19 commented Feb 6, 2025

Removes the repo_name attribute for gazelle and rules_go deps in MODULE.bazel and replaces all usaged of them. Tested all targets are valid using bazel query:

 bazel query //...
WARNING: For repository 'bazel_features', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_go', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'zlib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_github_grpc_grpc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'aspect_bazel_lib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
//:.aspect_rules_js/node_modules/@[email protected]
//:.aspect_rules_js/node_modules/@[email protected]/dir
...
//toolchain/scala:default_toolchain
//toolchain/scala:minimal_direct_source_deps

@chenxiao0228
Copy link

Thanks for working on this! it would be awesome to have full bzlmod support.

@pcj any concerns merging this in?

@pcj pcj merged commit 62a16a3 into stackb:pcj/bzlmod-wip Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants