Skip to content

Propagate transitive and verbose flags in gogo_* rules #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Propagate transitive and verbose flags in gogo_* rules #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions github.com/gogo/protobuf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,14 +237,17 @@ def gogo_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogo_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -337,14 +340,17 @@ def gogo_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogo_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -606,14 +612,17 @@ def gogofast_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofast_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -706,14 +715,17 @@ def gogofast_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofast_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -975,14 +987,17 @@ def gogofaster_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofaster_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -1075,14 +1090,17 @@ def gogofaster_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofaster_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogo_grpc_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogo_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogo_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogo_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogo_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogo_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogofast_grpc_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogofast_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofast_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogofast_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogofast_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofast_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogofaster_grpc_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogofaster_grpc_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofaster_grpc_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
5 changes: 4 additions & 1 deletion github.com/gogo/protobuf/gogofaster_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ def gogofaster_proto_library(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

gogofaster_proto_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down
3 changes: 2 additions & 1 deletion go/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ load("//:plugin.bzl", "proto_plugin")

proto_plugin(
name = "go",
options = ["paths=source_relative"],
outputs = [".pb.go"],
tool = "@com_github_golang_protobuf//protoc-gen-go",
transitivity = {
Expand All @@ -12,7 +13,7 @@ proto_plugin(

proto_plugin(
name = "grpc_go",
options = ["plugins=grpc"],
options = ["paths=source_relative", "plugins=grpc"],
outputs = [".pb.go"],
tool = "@com_github_golang_protobuf//protoc-gen-go",
transitivity = {
Expand Down
10 changes: 8 additions & 2 deletions tools/exgen/gogo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ def {{ .Rule.Name }}(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

{{ .Rule.Base}}_{{ .Rule.Kind }}_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down Expand Up @@ -58,14 +61,17 @@ def {{ .Rule.Name }}(**kwargs):
deps = kwargs.get("deps")
importpath = kwargs.get("importpath")
visibility = kwargs.get("visibility")
transitive = kwargs.pop("transitive", True)
verbose = kwargs.pop("verbose", 0)
go_deps = kwargs.get("go_deps", [])

name_pb = name + "_pb"

{{ .Rule.Base}}_{{ .Rule.Kind }}_compile(
name = name_pb,
deps = deps,
transitive = True,
transitive = transitive,
verbose = verbose,
plugin_options = get_importmappings(kwargs.pop("importmap", {})) + wkt_mappings,
visibility = visibility,
)
Expand Down