stgit.el improvements #2 #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prepare for lexical-binding and to make the code clearer.
Prevents issues for users that force color in their git config.
This silences warnings like "reference to free variable" and allows us to add docstrings.
Eliminates lots of "reference to free variable" warnings.
|
This is really great. Thank you for this. Sorry about the delay getting it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Back again with another round of improvements!
A notable improvement is "Allow empty descriptions" as that was causing spurious and frustrating errors while trying to use it.
Admittedly most of this (6 out of the 8 commits) is just satiating the compiler and should hopefully not cause any changes whatsoever.
Locally testing these changes seems to work but due to a lack of a test suite and the fact that I don't personally use every available code path here, there is a decent chance I broke something somewhere.