feat: implement new menu design #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12889242925Details
💛 - Coveralls |
kantord
force-pushed
the
implement-new-menu-design
branch
from
d16a05c to
77e6e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
This implements the new menu design. Fixes #136 #135 See the implementation:
Record_select-area_20250121152358.mp4
Also adds a script (and readme section) for generating custom icons
Gotchas
For some reason I had to remove the router provider for ui-kit that I added earlier today, because external links stopped working. I tried to debug this for a bit but couldn't figure out the reason. However now both external and internal links seem to work fine So I guess we are ok for now
I didn't replace the entire icon set, we are still using Lucide icons. I only added the custom icons for stuff that didn't have a good enough equivalent in Lucide. We can replace all icons if we want, but I thought this is not a super urgent thing
The design has separate sections for the help menu, not only a divider. But I couldn't manage to make the section headers look like in the design without a custom className. I'm still looking into how to fix this without custom class names, maybe using a PR for ui-kit itself. So I removed those changes for this PR, and I deviated from the design slightly in the wording until the headers are added back in.