Skip to content

fix(alert detected type): don't default to leaked secret #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jan 27, 2025
Merged

fix(alert detected type): don't default to leaked secret #208

merged 23 commits into from
Jan 27, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Jan 27, 2025 •
edited
Loading

  • fixes a minor nit in getIssueDetectedType where we were defaulting to "leaked" secret if an alert was not malicious
  • fixes a failing test in AlertsTable caused by isColumnHeader being applied to the time, rather than the "type" of alert

kantord and others added 21 commits January 24, 2025 12:27
@kantord
rename timestamp coloumn to time
001139a
@kantord
make 'time' the first column
4c2c604
@kantord
use relative date time format in alerts table
474f9a2
@kantord
rename trigger type column to type
e68e4c2
@kantord
clamp trigger markdown to a single lineoverflowoverflow
70ceabb
@kantord
remove code and file columns from alerts table
fa48c6e
@kantord
rename trigger token column to event
a956b9e
@kantord
.
bc6542f
@kantord
implement event column content correctly
04860b3
@kantord
implement type column values
5e92cbe
@kantord
add note about ongoing discussion on message type
f7c9c73
@kantord
fix mapping alerts type
3a778b2
@kantord
Merge branch 'main' into alerts-table-refactor
2a742d8
@kantord
display detected problem properly
c07eeac
@kantord
Merge branch 'main' into alerts-table-refactor
7d55f72
@kantord
configure alerts table width
b75fc79
@alex-mcgovern
fix(getIssueDetectedType): don't default to leaked_secret
d013d4e
@alex-mcgovern
fix(AlertsTable): failing test
360af2c
@alex-mcgovern
chore: tidy up
4c5cbac
@kantord
fix table column sizing using <ResizableTableContainer />
60bda23
@alex-mcgovern
Merge branch 'alerts-table-refactor' into fix/issue-detected-type/don…
5063b18 
…'t-default-to-leaked-secret
Base automatically changed from alerts-table-refactor to main January 27, 2025 12:07
@kantord kantord enabled auto-merge (squash) January 27, 2025 13:14
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12990646744

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 68.305%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/utils.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 12988609897: 0.07%
Covered Lines: 768
Relevant Lines: 1023
💛 - Coveralls

@kantord kantord merged commit 0e64263 into main Jan 27, 2025
8 checks passed
@kantord kantord deleted the fix/issue-detected-type/don't-default-to-leaked-secret branch January 27, 2025 14:09
@stacklokbot stacklokbot mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppescg peppescg peppescg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-mcgovern @coveralls @peppescg @kantord