Skip to content

Update the Facebook secret key regex at signatures.yaml #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update the Facebook secret key regex at signatures.yaml #1000

merged 1 commit into from
Feb 10, 2025

Conversation

rdimitrov
Copy link
Member

This should fix a warning in the CodeGate logs -

2025-02-10T14:14:32.668331Z [warning  ] Invalid regex pattern '(?i)(facebook|fb)(.{0,20})?(?-i)['\"][0-9a-f]{32}': missing : at position 31 lineno=144 module=signatures pathname=/Users/dimitrovr/stacklok/codegate/src/codegate/pipeline/secrets/signatures.py
2025-02-10T14:14:32.668459Z [warning  ] Skipping invalid regex for Meta:Facebook Secret Key lineno=183 module=signatures pathname=/Users/dimitrovr/stacklok/codegate/src/codegate/pipeline/secrets/signatures.py

@rdimitrov rdimitrov self-assigned this Feb 10, 2025
@rdimitrov rdimitrov merged commit cf7a92f into main Feb 10, 2025
9 checks passed
@rdimitrov rdimitrov deleted the fix-warning branch February 10, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aponcedeleonch aponcedeleonch aponcedeleonch approved these changes

Assignees

@rdimitrov rdimitrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdimitrov @aponcedeleonch