Record output from non-streaming responses in DB #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #938 We were not recording the output of the non-streamed responses in the DB. In our API we're filtering out all the conversations that don't contain an answer. Since we were not recording non-streamed responses we were filtering out the entire conversation if it was non-streamed. Note: This still doesn't add an output pipeline for non-streamed responses.
aponcedeleonch
requested review from
blkt,
jhrozek,
JAORMX,
yrobla and
rdimitrov
rdimitrov
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #938
We were not recording the output of the non-streamed responses in the DB. In our API we're filtering out all the conversations that don't contain an answer. Since we were not recording non-streamed responses we were filtering out the entire conversation if it was non-streamed.
Note: This still doesn't add an output pipeline for non-streamed responses.