Skip to content

Make copilot integration tests pass on the replace-litellm branch #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Feb 19, 2025

Includes the change from PR #1108 and then ports a recent change to the new stream chunk API.

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.
@blkt blkt merged commit d3dd57d into chore/replace-litellm Feb 19, 2025
@blkt blkt deleted the integration-tests branch February 19, 2025 14:05
blkt pushed a commit that referenced this pull request Feb 19, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Feb 20, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Feb 21, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Feb 21, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Feb 21, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Feb 25, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
blkt pushed a commit that referenced this pull request Mar 2, 2025
)

* Fix copilot secret unredaction

The copilot provider always sends `cleanup_sensitive` set to `False` as it
manages the context itself. On streams where `finish_stream` was set to
`False` as well, we would have yielded the rest of the context buffer though
which would break secret unredaction.

To reproduce, ask Copilot to make a simple modification in a file
containing secrets so that it's forced to print the secrets back to you.

* Port recent copilot change to the new chunk API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants