This repository was archived by the owner on Jun 5, 2025. It is now read-only.
feat: create Dockerfile for shipping codegate as image #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Nov 28, 2024
jhrozek
reviewed
Nov 28, 2024
Create a makefile to build the image, and Dockerfile to specify the build steps. Modify README to give instructions to run the codegate image Closes: #62
Comment on lines
+22
to
+30
| # Copy only the files needed for installing dependencies | ||
| COPY pyproject.toml poetry.lock* /app/ | ||
|
|
||
| # Configure Poetry and install dependencies | ||
| RUN poetry config virtualenvs.create false && \ | ||
| poetry install --no-dev | ||
|
|
||
| # Copy the rest of the application | ||
| COPY . /app |
There was a problem hiding this comment.
I'm not a 100% sure. But I think that if we copy the complete application into the app directory and then run poetry install --no-dev it should install codegate module. In other words, doing
COPY . /app
# Configure Poetry and install dependencies
RUN poetry config virtualenvs.create false && \
poetry install --no-dev
Would already enable us to do
from codegate. # import whatever submoduleThis has the benefit that we would avoid changing the PYTHONPATH further down the file
# Set the PYTHONPATH environment variable
ENV PYTHONPATH=/app/src
It's just a nit I noticed. I think as it is it should do the trick
aponcedeleonch
approved these changes
Nov 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a makefile to build the image, and Dockerfile to specify the build steps. Modify README to give instructions to run the codegate image
Closes: #62