-
Notifications
You must be signed in to change notification settings - Fork 77
Strip code snippets through a client interface #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhrozek
wants to merge
1
commit into
main
Choose a base branch
from
strip_code_interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import re | ||
from abc import ABC, abstractmethod | ||
from typing import Dict, Type | ||
|
||
from codegate.clients.clients import ClientType | ||
|
||
|
||
class ClientInterface(ABC): | ||
"""Secure interface for client-specific message processing""" | ||
|
||
@abstractmethod | ||
def strip_code_snippets(self, message: str) -> str: | ||
"""Remove code blocks and file listings to prevent context pollution""" | ||
pass | ||
|
||
|
||
class GenericClient(ClientInterface): | ||
"""Default implementation with strict input validation""" | ||
|
||
_MARKDOWN_CODE_REGEX = re.compile(r"```.*?```", re.DOTALL) | ||
_MARKDOWN_FILE_LISTING = re.compile(r"⋮...*?⋮...\n\n", flags=re.DOTALL) | ||
_ENVIRONMENT_DETAILS = re.compile( | ||
r"<environment_details>.*?</environment_details>", flags=re.DOTALL | ||
) | ||
|
||
_CLI_REGEX = re.compile(r"^codegate\s+(.*)$", re.IGNORECASE) | ||
|
||
def strip_code_snippets(self, message: str) -> str: | ||
message = self._MARKDOWN_CODE_REGEX.sub("", message) | ||
message = self._MARKDOWN_FILE_LISTING.sub("", message) | ||
message = self._ENVIRONMENT_DETAILS.sub("", message) | ||
return message | ||
|
||
|
||
class ClineClient(ClientInterface): | ||
"""Cline-specific client interface""" | ||
|
||
_CLINE_FILE_REGEX = re.compile( | ||
r"(?i)<\s*file_content\s*[^>]*>.*?</\s*file_content\s*>", re.DOTALL | ||
) | ||
|
||
def __init__(self): | ||
self.generic_client = GenericClient() | ||
|
||
def strip_code_snippets(self, message: str) -> str: | ||
message = self.generic_client.strip_code_snippets(message) | ||
return self._CLINE_FILE_REGEX.sub("", message) | ||
|
||
|
||
class ClientFactory: | ||
"""Secure factory with updated client mappings""" | ||
|
||
_implementations: Dict[ClientType, Type[ClientInterface]] = { | ||
ClientType.GENERIC: GenericClient, | ||
ClientType.CLINE: ClineClient, | ||
ClientType.KODU: ClineClient, | ||
} | ||
|
||
@classmethod | ||
def create(cls, client_type: ClientType) -> ClientInterface: | ||
return cls._implementations.get(client_type, GenericClient)() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems similar to the regex and functionality we have in message_extractor.py. Could we reuse that? It's just a thought.. feel free to disregard the comment if you think it's too hard or doesn't make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this is great. I guess we can at least move the regexes to the same interface or unify them.