Created necessary methods for Persona CRUD #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #1219 Some changes in this PR - Renamed Semantic Router to PersonaManager: The motivation is that the only semantic routing we're doing is based on persona. So lets just call it that wat - Created update and delete methods for Persona - Added tests for the whole Persona CRUD
JAORMX
requested changes
Mar 6, 2025
| persona = await dbreader.get_persona_by_name(persona_name) | ||
| if not persona: | ||
| raise HTTPException(status_code=404, detail=f"Persona {persona_name} not found") | ||
| return persona |
There was a problem hiding this comment.
should we be catching the exception when a persona doesn't exist?
| raise HTTPException(status_code=404, detail=f"Persona {persona_name} not found") | ||
| return persona | ||
| except Exception as e: | ||
| if isinstance(e, HTTPException): |
There was a problem hiding this comment.
Should the db reader be raising an HTTP exception? This sounds off
JAORMX
reviewed
Mar 6, 2025
| async def list_personas() -> List[Persona]: | ||
| """List all personas.""" | ||
| try: | ||
| personas = await dbreader.get_all_personas() |
There was a problem hiding this comment.
why not leverage the persona manager here to keep the code consistent? Adding the dbreader here seems like an antipattern
JAORMX
reviewed
Mar 6, 2025
| raise HTTPException(status_code=500, detail="Internal server error") | ||
|
|
||
|
|
||
| @v1.get("/personas/{persona_name}", tags=["Personas"], generate_unique_id_function=uniq_name) |
There was a problem hiding this comment.
Can we use an annotated object to do input validation on persona_name? I'd like to restrict the characters that folks can use here to prevent vulnerabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1219
Some changes in this PR