This repository was archived by the owner on Jun 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Add instance
table along with init code.
#1234
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
63 changes: 63 additions & 0 deletions
63
migrations/versions/2025_03_05_2126-e4c05d7591a8_add_installation_table.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
"""add installation table | ||
|
||
Revision ID: e4c05d7591a8 | ||
Revises: 3ec2b4ab569c | ||
Create Date: 2025-03-05 21:26:19.034319+00:00 | ||
|
||
""" | ||
|
||
from typing import Sequence, Union | ||
|
||
from alembic import op | ||
import sqlalchemy as sa | ||
|
||
|
||
# revision identifiers, used by Alembic. | ||
revision: str = "e4c05d7591a8" | ||
down_revision: Union[str, None] = "3ec2b4ab569c" | ||
branch_labels: Union[str, Sequence[str], None] = None | ||
depends_on: Union[str, Sequence[str], None] = None | ||
|
||
|
||
def upgrade() -> None: | ||
op.execute("BEGIN TRANSACTION;") | ||
|
||
op.execute( | ||
""" | ||
CREATE TABLE IF NOT EXISTS instance ( | ||
id TEXT PRIMARY KEY, -- UUID stored as TEXT | ||
created_at DATETIME NOT NULL | ||
); | ||
""" | ||
) | ||
|
||
op.execute( | ||
""" | ||
-- The following trigger prevents multiple insertions in the | ||
-- instance table. It is safe since the dimension of the table | ||
-- is fixed. | ||
|
||
CREATE TRIGGER single_instance | ||
BEFORE INSERT ON instance | ||
WHEN (SELECT COUNT(*) FROM instance) >= 1 | ||
BEGIN | ||
SELECT RAISE(FAIL, 'only one instance!'); | ||
END; | ||
""" | ||
) | ||
|
||
# Finish transaction | ||
op.execute("COMMIT;") | ||
|
||
|
||
def downgrade() -> None: | ||
op.execute("BEGIN TRANSACTION;") | ||
|
||
op.execute( | ||
""" | ||
DROP TABLE instance; | ||
""" | ||
) | ||
|
||
# Finish transaction | ||
op.execute("COMMIT;") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have a trigger that prevents deletion of the one row as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid adding a constraint on deletion, it becomes cumbersome to modify the table since AFAIK you cannot disable triggers temporarily in sqlite, which means you'd have to rely on
DROP TABLE/CREATE TABLE
to fix any sort of issue.Additionally, it's hard to delete that record by mistake since there's no
delete_instance
routine inDbRecorder
and initialization takes care of recreating it.I'm inclined to let this as is, but I'm not religious about it, we can add it now or later anyway.