This repository was archived by the owner on Jun 5, 2025. It is now read-only.
A hotfix for the FIM pipeline #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a real fix but a hotfix. The part that is needed and will be reused later is that we need to select the proper pipeline for FIM/non-FIM. What makes it a hotfix is that we shortcut for FIM requests as if we had no pipeline - this is OK for now because our FIM output pipeline is empty anyway, but we'll have to fix it. For some reason, piping the FIM output through the output pipeline throws errors. I'll look into that a bit more, but if we want to get the FIM output unblocked and without errors, this helps. Related: #351
lukehinds
approved these changes
Dec 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a real fix but a hotfix. The part that is needed and will be
reused later is that we need to select the proper pipeline for
FIM/non-FIM. What makes it a hotfix is that we shortcut for FIM requests
as if we had no pipeline - this is OK for now because our FIM output
pipeline is empty anyway, but we'll have to fix it. For some reason,
piping the FIM output through the output pipeline throws errors.
I'll look into that a bit more, but if we want to get the FIM output
unblocked and without errors, this helps.
Related: #351