Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

fix: add monitoring for idle connections and close them #516

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: add monitoring for idle connections and close them #516

merged 1 commit into from
Jan 9, 2025

Conversation

yrobla
Copy link
Contributor

@yrobla yrobla commented Jan 8, 2025

need to find a better way

lukehinds
lukehinds reviewed Jan 8, 2025
View reviewed changes
Copy link

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a bit more context to what the change introduces, I figure these are asyncio methods, is 10 seconds sufficient? Perhaps there might be cases where the model is calculating a large prompt and exceeds that value?

@lukehinds lukehinds merged commit 1d0c5f5 into main Jan 9, 2025
2 checks passed
@lukehinds lukehinds deleted the debug_idle_connections branch January 9, 2025 06:35
@yrobla yrobla mentioned this pull request Jan 9, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukehinds lukehinds lukehinds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrobla @lukehinds