Skip to content

Use Windows ARM64 for RTools CI #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2025
Merged

Use Windows ARM64 for RTools CI #3177

merged 12 commits into from
Apr 24, 2025

Conversation

andrjohns
Copy link
Collaborator

Summary

Windows ARM runners are now available for public repos, so we can add them to the CI. I've just replaced the existing windows runners, but can also add them separately if we want both x86-64 & arm64 rtools.

The setup-r action doesn't support arm64, so I've just added a step to manually install RTools

Tests

N/A - existing tests should still pass

Side Effects

N/A

Release notes

Added Windows ARM64 to the Github CI

Checklist

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member

There are several orders of magnitude more x86 windows users than ARM, so if we do test this at all we should do it in addition rather than as a replacement

@andrjohns
Copy link
Collaborator Author

There are several orders of magnitude more x86 windows users than ARM, so if we do test this at all we should do it in addition rather than as a replacement

Ah yeah true, will add both

@andrjohns andrjohns merged commit 8efa507 into develop Apr 24, 2025
34 checks passed
@WardBrian WardBrian deleted the winarm64-ci branch April 24, 2025 13:53
@WardBrian
Copy link
Member

It looks like sometimes these jobs get stuck installing rtools, e.g: https://github.com/stan-dev/math/actions/runs/14649317253/job/41111049475?pr=3171

1 hour and counting just in the install step

@WardBrian
Copy link
Member

I can't tell if it's a rate limiting issue or the installer thats hanging. If its the former we could add an authorization header to Invoke-WebRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants