Skip to content

Conversation

@ilyalesokhin-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-lowering/src/optimizations/test_data/match_optimization line 768 at r1 (raw file):

  (v7: test::Color) <- Color::Red(v2)
End:
  Return(v6, v7)

looks like this test is broken :(

Code quote:

Return(v6, v7)

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-lowering/src/optimizations/test_data/match_optimization line 1656 at r1 (raw file):


//! > test_comments
// TODO(orizi): Enable the optimization for this case as well.

it is applicable when we apply the return optimization

Code quote:

// TODO(orizi): Enable the optimization for this case as well.

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-lowering/src/optimizations/test_data/match_optimization line 768 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

looks like this test is broken :(

fixed

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-lowering/src/optimizations/test_data/match_optimization line 1656 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

it is applicable when we apply the return optimization

i don't understand.


a discussion (no related file):
is this preferable? note that it "hide" part of what the optimization actually did.
maybe add it as a boolean for the test params?

@ilyalesokhin-starkware
Copy link
Contributor Author

Previously, orizi wrote…

is this preferable? note that it "hide" part of what the optimization actually did.
maybe add it as a boolean for the test params?

what does it hide?

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)


a discussion (no related file):

Previously, ilyalesokhin-starkware wrote…

what does it hide?

the name and the block ids change further, and remappings are deleted.

@ilyalesokhin-starkware
Copy link
Contributor Author

Previously, orizi wrote…

the name and the block ids change further, and remappings are deleted.

in the input to the optimization, not in the result.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion


a discussion (no related file):

Previously, ilyalesokhin-starkware wrote…

in the input to the optimization, not in the result.

oh - nm.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants