Skip to content

Conversation

@0xLogicalx
Copy link
Contributor

Stop cloning the first Sierra function when setting up the executable wrapper. Reuse the borrowed function reference when creating the wrapper info, keeping behaviour identical while avoiding redundant work.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @0xLogicalx)

@orizi orizi enabled auto-merge November 21, 2025 19:21
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0xLogicalx)


crates/cairo-lang-executable/src/compile.rs line 231 at r1 (raw file):

    // Since we build the entry point asking for a single function - we know it will be first, and
    // that it will be available.
    let executable_func = &sierra_program.funcs[0];

run ./scripts/rust_fmt.sh

@0xLogicalx
Copy link
Contributor Author

Ran ./scripts/rust_fmt.sh; formatting is applied and the updated changes are pushed. Thanks for the review!

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pushed apparently.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0xLogicalx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants