Implement EntryRespository::whereInId()#417
Merged
ryanmitchell merged 1 commit intoOct 10, 2025
Merged
Conversation
d3689d9 to
9f6271c
Compare
Contributor
|
Thanks for the PR. The goal of this driver is to match the functionality and contract methods provided by core. So for this to merge the core PR would be to be accepted - il leave that for the core team to decide. |
Member
|
Marking this as a draft until the Core PR has been merged. |
Contributor
|
@nadinengland now that the core PR has merged do you intend to update this to match? |
9f6271c to
501f528
Compare
Contributor
Author
|
Hey @ryanmitchell, yes my branch has been updated to reflect the core's method. Thanks for your patience on my delay! |
EntryRespository::whereInId()
Contributor
|
This looks good to me. Thanks for your work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
whereInIdtoEntryRepository. See docs PRNotable functionality:
Relevancy to core
This is part of a wider piece of work I've start to add a fairly large reduction in DB queries to the
statamic/eloquent-driver. The principal idea is to route as many components as possible through the repositories. As I was adding this to the package, parity with the core Repository contract felt good as well: PR on statamic/cms.Note: original method was
findByIds.