Statamic v6 Support #394
Draft
Statamic v6 Support #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add config to enforce trailing slashes on sitemap. * Handle sitemap config. * Fix `home_url` trailing slash in generated meta. * Make config a bit more generic. * Add trailing slash test coverage for URLs in sitemap. * Add missing test coverage for `next_url`and `prev_url`. * Add test coverage to ensure trailing slashes are output in meta cascade * Implement trailing slashes in cascade. * Pass failing tests around trailing slash on canonical. * Add coverage to ensure trailing slashes go back to how user had them pre-cascade. * Pass all tests again. * Temporary constraint for CI, since v6 is on master atm. * Exact version. * Tighten constraints more. * Drop old PHP/Laravel versions from test matrix because Statamic v6 does. * Kick test suite. * More updates to test matrix. * This PR in core isn't merged yet. * Revert `urls.enforce_trailing_slashes` config on SEO Pro side, as discussed. We think most use cases revolve around use cases like Netlify/etc., so it's probable that the user then wants trailing slashes on all URLs, not just in SEO meta/sitemap. The fact that we were turning it on and off, could end up generating inaccurate stache. We can revisit later if this is needed. * This test is really only concerned with pagination. * Add basic test coverage for the actual generated meta. * Add note in documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: