Skip to content

fix: 8.4 CLI on windows #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

SRWieZ
Copy link

@SRWieZ SRWieZ commented Dec 25, 2024

As suggested here: #3 (comment), php_win32_init_gettimeofday(); no longer exists in PHP 8.4.

You can find a working build here: https://github.com/SRWieZ/fork-nativephp-php-bin/actions/runs/12487358547/job/34848443622?pr=1.

Summary of changes

  • Copied cli_static to _80, _81, _82, _83
  • Created a new patch for 8.4

@crazywhalecc crazywhalecc changed the base branch from master to 84beta January 13, 2025 01:12
@crazywhalecc
Copy link
Member

Sorry for late reply. It is best to use fallback compatibility for phpmicro patches to reduce duplicate patch files: if the patch for 80 is applicable to 80~83, only cli_static_80.patch is needed.

I'll make adjustments later, thanks for contributing to the project!

@crazywhalecc crazywhalecc merged commit 71dcd4a into static-php:84beta Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants