Skip to content

Fix syscall fail issue and missing code #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

Conversation

advaita-saha
Copy link
Contributor

@advaita-saha advaita-saha commented Apr 24, 2025

@advaita-saha advaita-saha requested a review from jangko April 24, 2025 09:39
Copy link
Contributor Author

@advaita-saha advaita-saha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best approach to be done here
If the code doesn't exist, we don't need to process further over the EVM

let code: CodeBytesRef = vmState.getCallCode(WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS)
if code.bytes.len == 0:
return err("processDequeueWithdrawalRequests: no code found for withdrawal requests contract")

@jangko
Copy link
Contributor

jangko commented Apr 24, 2025

So it's a breaking changes I see. I think the t8n test vectors must be fixed too by adding predeployed contract code.
Of course you will see additional mismatch like stateroot mismatch too, but simply replace it with new value should solve the problem.

@advaita-saha
Copy link
Contributor Author

Screenshot 2025-04-24 at 5 00 09 PM

@advaita-saha advaita-saha marked this pull request as ready for review April 24, 2025 17:25
Copy link
Contributor

@jangko jangko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@advaita-saha advaita-saha merged commit ed07dc9 into master Apr 25, 2025
10 checks passed
@advaita-saha advaita-saha deleted the fix-syscall-fail-issue branch April 25, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants