-
Notifications
You must be signed in to change notification settings - Fork 128
Fix syscall fail issue and missing code #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best approach to be done here
If the code doesn't exist, we don't need to process further over the EVM
nimbus-eth1/execution_chain/core/executor/process_transaction.nim
Lines 204 to 206 in a91406e
let code: CodeBytesRef = vmState.getCallCode(WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS) | |
if code.bytes.len == 0: | |
return err("processDequeueWithdrawalRequests: no code found for withdrawal requests contract") |
So it's a breaking changes I see. I think the t8n test vectors must be fixed too by adding predeployed contract code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
EIP-7002 updated along with EIP-7215
https://github.com/ethereum/EIPs/pull/9508/files
https://github.com/ethereum/EIPs/pull/9582/files