add tcp-pinger for mailservers #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (107)
|
|
Currently this doesn't seem to work as I'm unable to make and RPC request: curl -s localhost:8545 -H 'content-type: application/json' \
-d '{"jsonrpc":"2.0","method":"mailservers_Ping","params":[["1.1.1.1:53"], 1000],"id":1}' | jq{
"jsonrpc": "2.0",
"id": 1,
"error": {
"code": -32601,
"message": "the method mailservers_Ping does not exist/is not available"
}
}NOTE: Turns our the call name needs to be lowercase: |
adambabik
reviewed
Nov 13, 2019
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
3 times, most recently
from
aed9e15 to
0409524
Compare
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
from
0409524 to
5de9033
Compare
adambabik
reviewed
Nov 13, 2019
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
5 times, most recently
from
15b5060 to
f3c7f0d
Compare
adambabik
approved these changes
Nov 13, 2019
|
Error in the CI: |
|
Android seems broken, not sure why: Something similar goes for iOS: |
This is added in Go 1.13 and I think we still use 1.12 in the CI. https://sourcegraph.com/github.com/golang/sys/-/blob/plan9/syscall_plan9.go#L258 it's clearly tsTimeout := unix.Timespec{Nsec: int32(timeout.Nanoseconds())} |
|
Yeah, I get it, but why are you looking at a |
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
5 times, most recently
from
8c8675a to
8a4bf5d
Compare
|
Now I have no idea why iOS fails or the linting in tests... |
Problem with iOS. Sorry, I looked in a wrong file. But generally there are some issues with types so it just needs fixing as told. And linter now... Did you update Go in the CI? |
|
Same goes for type Timespec struct {
Sec int32
Nsec int32
}http://www.golang.so/src/syscall/ztypes_darwin_arm.go type Timespec struct {
Sec int64
Nsec int64
}http://www.golang.so/src/syscall/ztypes_darwin_arm64.go There is a helper method but it's not exported and it uses strict types: func setTimespec(sec, nsec int64) Timespec {
return Timespec{Sec: int32(sec), Nsec: int32(nsec)}
} |
|
Found the solution to func TimeToTimespec(t time.Time) (Timespec, error) |
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
2 times, most recently
from
9f11977 to
be8e8f6
Compare
|
@adambabik I managed to fix the build errors, but I have no clue what the linter issues are about. Also, I tried building it with Which makes no sense because the method clearly exists: func (d Duration) Milliseconds() int64https://golang.org/pkg/time/#Duration.Milliseconds |
|
I think this issue - golang/go#28564 - indicates that the |
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
9 times, most recently
from
21b4b84 to
b68dc98
Compare
|
I ran a build of |
|
I have no idea why it started complaining about returned C types. In 153124f, this error is ignored. I reported this behaviour in golangci/golangci-lint#858. There is a simple case how to reproduce it. |
|
@adambabik thanks for fixing that, then I guess we are ready to merge unless you think there's anything else this might be missing. I added a small |
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
from
153124f to
69376e0
Compare
jakubgs
changed the title
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
from
69376e0 to
6bd667d
Compare
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
from
6bd667d to
476f01e
Compare
adambabik
approved these changes
Nov 15, 2019
Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
force-pushed
the
mailserver-tcp-pinger
branch
from
352fa0c to
88c4876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of implementation of an RPC call for checking latency of mailservers.
Partially resolves status-im/status-mobile#9394.
Status: READY