WIP: add styling for new PR #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stefanv
reviewed
May 19, 2025
| @@ -1,35 +1,40 @@ | |||
| <h1></h1> | |||
There was a problem hiding this comment.
Doesn't removing this again make us end up with a bigger title?
There was a problem hiding this comment.
Yes. But leaving it adds a new element that has non zero height. Rather than adding a blank header and removing it in the CSS, I propose just leaving it as is for now? Semantically, it's not clear but I believe we should have an h2 here.
There was a problem hiding this comment.
OK, just curious how we replicate what we had before: a smaller header.
There was a problem hiding this comment.
For now, you can add a style rule to the .footer block:
& h1 {
font-size: 1.5rem;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies jupyter-book/myst-theme#565
It should be fairly self-explanatory --- the interesting parts are in jupyter-book/myst-theme#565
Note that jupyter-book/myst-theme#565 annotates the footer with a
.footerclass for easier targeting (avoiding the user needing to fiddle with specificity rules)