Repository navigation
Remove v30 SDK type names migration entry - #2136
leighmcculloch wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only removal is consistent across the guide and its index.
0 open findings
What changed in this PR
Removes a v30 migration entry because the type-name rejection is not considered a meaningful breaking change.
Changes:
- Delete the migration guide entry.
- Remove its index text, link, and module declaration.
| File | Description |
|---|---|
soroban-sdk/src/_migrating/v30_sdk_type_names.rs |
Removes the guide entry. |
soroban-sdk/src/_migrating.rs |
Removes references to the entry. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Classification: patch. The PR only removes a documentation page from the
To check: if This classification is advisory. The author and reviewer decide the release type.
|
What
Remove the v30 migration guide entry about naming types, events, and errors with soroban-sdk type names.
Why
The migration guide is for meaningful breaking changes, and this isn't one:
contracttypealready rejected these names and it was just the way that the rejection happened that changed.Known limitations
N/A
SemVer Change
vX._._) - Breaking change to the public API.v_.Y._) - Additive change to the public API.v_._.Z) - No change to the public API.