Skip to content

Remove v30 SDK type names migration entry - #2136

Open
leighmcculloch wants to merge 2 commits into
mainfrom
remove-sdk-type-names-migration
Open

leighmcculloch wants to merge 2 commits into
mainfrom
remove-sdk-type-names-migration

Conversation

@leighmcculloch

Copy link
Copy Markdown
Member

What

Remove the v30 migration guide entry about naming types, events, and errors with soroban-sdk type names.

Why

The migration guide is for meaningful breaking changes, and this isn't one: contracttype already rejected these names and it was just the way that the rejection happened that changed.

Known limitations

N/A

SemVer Change

  • Major (vX._._) - Breaking change to the public API.
  • Minor (v_.Y._) - Additive change to the public API.
  • Patch (v_._.Z) - No change to the public API.

@leighmcculloch
leighmcculloch requested a review from a team October 14, 2026 00:49
@leighmcculloch leighmcculloch added this to the 30.0.0 milestone Oct 14, 2026
@leighmcculloch
leighmcculloch marked this pull request as ready for review October 14, 2026 00:50
Copilot AI lite review requested due to automatic review settings October 14, 2026 00:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only removal is consistent across the guide and its index.

0 open findings

What changed in this PR

Removes a v30 migration entry because the type-name rejection is not considered a meaningful breaking change.

Changes:

  • Delete the migration guide entry.
  • Remove its index text, link, and module declaration.
File Description
soroban-sdk/​src/​_migrating/​v30_sdk_type_names.rs Removes the guide entry.
soroban-sdk/​src/​_migrating.rs Removes references to the entry.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Classification: patch. The PR only removes a documentation page from the _migrating docs module.

  • soroban-sdk/src/_migrating.rs and the deleted _migrating/v30_sdk_type_names.rs contain only doc comments and the pub mod declaration for them. No code, macro output, manifests or features changed. Rule: documentation changes are patch.
  • The removed pub mod v30_sdk_type_names was added during the unreleased v30 cycle. There is no v30* tag, only v29.0.1, so no published release exposed it.
  • .semver/cargo-semver-checks.txt failed with unsupported rustdoc format v61 (supported: v55–v57). The classification is from the diff alone.

To check: if v30_sdk_type_names shipped in a pre-release, deleting a public module would count as major under "removing public items".

This classification is advisory. The author and reviewer decide the release type.

Generated by Semver Impact for #2136 · copilot · auto · 17.3 AIC · ⌖ 0.569 AIC · ⊞ 11.3K · ◷

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants