fix(runtime): use strict comparison when updating properties#6573
Merged
johnjenkins merged 2 commits intostenciljs:mainfrom Jan 27, 2026
Merged
fix(runtime): use strict comparison when updating properties#6573johnjenkins merged 2 commits intostenciljs:mainfrom
johnjenkins merged 2 commits intostenciljs:mainfrom
Conversation
Contributor
|
hey @SaiGovardhana - thanks for raising! I'm not sure if that's ok(?) |
Contributor
Author
Hi @johnjenkins , Are you talking about stencil web components being re-rendered?
|
johnjenkins
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, when component properties are updated, the runtime may treat distinct falsy values (like 0 and '') as equivalent due to loose equality checks. This can result in the DOM not reflecting the latest state, causing inputs or other properties to remain out of sync.
GitHub Issue Number: #6572
What is the new behavior?
Closes #6572
This PR introduces a strict comparison (!==) when updating element properties in the setAccessor function. Now, all value changes, including transitions between distinct falsy values, are properly propagated to the DOM.
Documentation
Does this introduce a breaking change?
Testing
Added a unit test for the numeric input wrapper to verify that the internal correctly updates when the component property changes between distinct falsy values (e.g., 0 -> "").
Verified that the DOM value always reflects the latest property, ensuring transitions between falsy states are handled correctly.