chore(deps): update dependency replace-in-file to v7 #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
force-pushed
the
renovate/replace-in-file-7.x
branch
from
0b16ac8 to
c4c71a9
Compare
renovate
bot
force-pushed
the
renovate/replace-in-file-7.x
branch
from
c4c71a9 to
2a06599
Compare
rwaskiewicz
added
the
Resolution: Refine
rwaskiewicz
force-pushed
the
renovate/replace-in-file-7.x
branch
from
266c07e to
0a5fc18
Compare
renovate
bot
force-pushed
the
renovate/replace-in-file-7.x
branch
from
0a5fc18 to
e444885
Compare
On upgrading to `replace-in-file` v7, our windows tests started to fail
in CI:
```
Run node index.js component tmp-component-starter
node index.js component tmp-component-starter
shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
✖ No files match the pattern: D:\a\create-stencil\create-stencil\tmp-component-starter\*
```
This was result of windows paths not being properly escaped. By adding
the configuration in this commit, we can resolve the issue - it uses
`\\` as a path separator only (not as an escape character)
STENCIL-969: update dependency replace-in-file to v7
rwaskiewicz
force-pushed
the
renovate/replace-in-file-7.x
branch
from
538309a to
0e46aa7
Compare
Contributor
|
Ran this locally by checking out this branch and: npm ci \
&& npm run build \
&& node index.js \
&& cd hello-world \
&& npm i \
&& npm t \
&& npm startWhere 'hello-world' is the name of the project used to create a component starter. Project built, ran tests, and dev server all ran as expected |
rwaskiewicz
requested review from
christian-bromann and
tanner-reits
and removed request for
alicewriteswrongs
rwaskiewicz
approved these changes
Dec 18, 2023
Comment on lines
+118
to
+120
| glob: { | ||
| windowsPathsNoEscape: true, | ||
| }, |
Contributor
There was a problem hiding this comment.
@tanner-reits || @christian-bromann can you offer a second set of eyes on this PR? I had to update this in order to get CI to pass on Windows. See 0e46aa7 for more information
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
tanner-reits
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^6.1.0->^7.0.0Release Notes
adamreisnz/replace-in-file (replace-in-file)
v7.0.2Compare Source
v7.0.1Compare Source
v7.0.0Compare Source
Strings provided to the
fromvalue are now escaped for regex matching when counting of matches is enabled. This is unlikely to result in any breaking changes, but as a precaution the major version has been bumped.Configuration
📅 Schedule: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.