chore(renovate): group download & upload artifact #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
rwaskiewicz
reviewed
Dec 18, 2023
Contributor
rwaskiewicz
left a comment
rwaskiewicz
left a comment
There was a problem hiding this comment.
LGTM - once https://github.com/ionic-team/stencil/pull/5193/files lands (which has the same content) and we can verify that this config works, we can merge
christian-bromann
approved these changes
Dec 18, 2023
rwaskiewicz
approved these changes
Jan 3, 2024
Contributor
rwaskiewicz
left a comment
rwaskiewicz
left a comment
There was a problem hiding this comment.
LGTM! This same change seems to be working in Stencil Core. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
The
actions/upload-artifactandactions/download-artifactare not grouped despite their shared peer dependencies on one another.GitHub Issue Number: N/A
What is the new behavior?
Creates a group in the Renovate config to group
actions/upload-artifactandactions/download-artifact.Does this introduce a breaking change?
Testing
Merge and find out
Other information