Skip to content

Achievements: Keep track of the earliest unlocked win condition #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stenzek merged 1 commit into from
Aug 9, 2025
Merged

Achievements: Keep track of the earliest unlocked win condition #3504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dep/rcheevos/src/rc_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,9 +954,9 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t
}
else if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_WIN)
{
first_win_condition_unlock = (first_win_condition_unlock == 0) ?
achievement->public_.unlock_time :
first_win_condition_unlock;
if (first_win_condition_unlock == 0 ||
(achievement->public_.unlock_time > 0 && achievement->public_.unlock_time < first_win_condition_unlock))
first_win_condition_unlock = achievement->public_.unlock_time;
}
}

Expand All @@ -979,7 +979,7 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t
* is unlocked, or all progression achievements are unlocked and no there are no win condition achievements. */
summary->beaten_time = 0;
if (num_progression_achievements > 0 && unlocked_progression_achievements == num_progression_achievements &&
(num_win_condition_achievements == 0 || first_win_condition_unlock > 0)) {
(num_win_condition_achievements == 0 || first_win_condition_unlock > 0)) {
summary->beaten_time = (num_win_condition_achievements == 0) ? last_progression_unlock : first_win_condition_unlock;
}

Expand Down
Loading