Qt: Disable UI of settings forced via gamedb, part two#3561
Merged
stenzek merged 1 commit intostenzek:masterfrom Sep 9, 2025
Merged
Qt: Disable UI of settings forced via gamedb, part two#3561stenzek merged 1 commit intostenzek:masterfrom
stenzek merged 1 commit intostenzek:masterfrom
Conversation
Missed these in the previous commit.
stenzek
reviewed
Sep 9, 2025
| m_dialog->hasGameTrait(GameDatabase::Trait::ForcePGXPVertexCache)); | ||
| SettingWidgetBinder::SetForceEnabled(m_ui.pgxpDisableOn2DPolygons, | ||
| m_dialog->hasGameTrait(GameDatabase::Trait::DisablePGXPOn2DPolygons)); | ||
| if (auto dbentry = m_dialog->getDatabaseEntry(); dbentry && dbentry->gpu_pgxp_preserve_proj_fp.has_value()) |
Owner
There was a problem hiding this comment.
Seems like this should be in a helper functions, since there will be other traits that behave the same way such as those above it.
Contributor
Author
There was a problem hiding this comment.
isn't gpu_pgxp_preserve_proj_fp the only one with an explicit true/false value in the db?
Owner
There was a problem hiding this comment.
I was more thinking from the perspective of "results in a forced value", e.g. force software renderer. But eh, I guess the availability kinda handles it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, missed these in #3558.
gpu_pgxp_preserve_proj_fpis treated specially because it can be set to true or false in the db.