Qt: Disable game compat comments button instead of hiding it#3639
Merged
stenzek merged 1 commit intostenzek:masterfrom Nov 25, 2025
Merged
Qt: Disable game compat comments button instead of hiding it#3639stenzek merged 1 commit intostenzek:masterfrom
stenzek merged 1 commit intostenzek:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for a longstanding Qt issue on macOS where the layout can get messed up in certain circumstances.
I don't remember the exact conditions under which it happens (something related to combo boxes and nested layouts inside grid layouts) but this is one of those cases[*]. The issue is purely aesthetic and admittedly fairly minor, so I'm totally ok with dropping the PR if you don't like the workaround.
[*] Notice in the screenshot how there's too much space above and below the "Compatibility" row. Moreover, the combo box is shifted slightly to the right instead of being aligned with the other controls above and below it. Removing the nested layout fixes the latter issue and reduces the amount of extra space (but doesn't fully eliminate it).