fix: only return Observable types for NestJS if the option is switched on

[alexkb]

We're using --ts_proto_opt=nestjs=true and wanted to remove Observable's being returned, so we tried --ts_proto_opt=returnObservable=false but it had no effect.

This PR fixes that issue so it does behave as expected. If it is incorrect, then I suggest you update the documentation to make it clear that returnObservable has no effect when nestjs=true. Thanks.

[tmthecoder]

Bump on this, using nestJS currently doesn't allow me to generate methods returning a promise

[alexkb]

@tmthecoder if you've got --ts_proto_opt=nestJs=true set then you should get Promise's along with Observable's, which you don't have to use. You won't get them though, if you've also set ts_proto_opt=returnObservable=true OR if your methods involve streams. Whatever the case, I've just re-synced this branch with main but I'm not sure what the maintainer wants to do here sorry.

[tmthecoder]

@alexkb I see the types be promise or observable for the controller implementations but the clients only have observable in the definitions, not sure why that is. I have the observable flag set to false manually in the proto gen command

[stephenh]

@alexkb Disclaimer that I don't use NestJS, but wouldn't just Promise<Villain> make more sense here as a return type?

I agree that your PR is already better than the previous Observable<T> | Promise<T> | T, which imo seems just kind of maddening to use as a caller, b/c you'd have to constantly be checking what the return value was.

...ah, maybe this interface is meant for the server-side to implement, and we want to give flexibility to the server to return what it wants.

Are these interfaces used by both the client and the server? I don't remember...

[rathod-sahaab]

@stephenh NestJS can also have non async function for controllers and services hence returning T makes sense
this will valid implementation of function within nest framework

   createPaymentLink(
      request: CreatePaymentLinkRequest,
   ): CreatePaymentLinkResponse {
      //...

      return {
         url: 'Payment at: https://lesgo.legolas.com',
      }
   }

This wont be allowed if we go with Promise<T>

[rathod-sahaab]

@alexkb shouldn't this also effect the client part which only returns the observable