fix all double callback errors - closes #166

Author: stephenlacy

lib/addRemote.js

@@ -11,7 +11,7 @@ module.exports = function (remote, url, opt, cb) {
     opt = {};
   }
   if (!cb || typeof cb !== 'function') cb = function () {};
-  if (!url) cb(new Error('gulp-git: Repo URL is required git.addRemote("origin", "https://github.com/user/repo.git")'));
+  if (!url) return cb(new Error('gulp-git: Repo URL is required git.addRemote("origin", "https://github.com/user/repo.git")'));
   if (!remote) remote = 'origin';
   if (!opt) opt = {};
   if (!opt.cwd) opt.cwd = process.cwd();
@@ -21,7 +21,7 @@ module.exports = function (remote, url, opt, cb) {
 
   var cmd = 'git remote add ' + opt.args + ' ' + escape([remote, url]);
   return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
-    if (err) cb(err);
+    if (err) return cb(err);
     if (!opt.quiet) gutil.log(stdout, stderr);
     cb();
   });

lib/addSubmodule.js

@@ -5,7 +5,7 @@ var exec = require('child_process').exec;
 
 module.exports = function (url, name, opt, cb) {
   if (!cb || typeof cb !== 'function') cb = function () {};
-  if (!url) cb(new Error('gulp-git: Repo URL is required git.submodule.add("https://github.com/user/repo.git", "repoName")'));
+  if (!url) return cb(new Error('gulp-git: Repo URL is required git.submodule.add("https://github.com/user/repo.git", "repoName")'));
   if (!name) name = '';
   if (!opt) opt = {};
   if (!opt.cwd) opt.cwd = process.cwd();
@@ -15,7 +15,7 @@ module.exports = function (url, name, opt, cb) {
 
   var cmd = 'git submodule add ' + opt.args + ' ' + url + ' ' + name;
   return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
-    if (err && cb) cb(err);
+    if (err && cb) return cb(err);
     if (!opt.quiet) gutil.log(stdout, stderr);
     if (cb) cb();
   });

lib/removeRemote.js

@@ -24,7 +24,7 @@ module.exports = function (remote, opt, cb) {
 
   var cmd = 'git remote remove ' + opt.args + ' ' + escape([remote]);
   return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
-    if (err) cb(err);
+    if (err) return cb(err);
     if (!opt.quiet) gutil.log(stdout, stderr);
     cb();
   });

lib/rm.js

@@ -27,7 +27,7 @@ module.exports = function (opt) {
     var cmd = 'git rm ' + escape(paths) + ' ' + opt.args;
     var that = this;
     exec(cmd, {cwd: cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
-      if (err) cb(err);
+      if (err) return cb(err);
       if (!opt.quiet) gutil.log(stdout, stderr);
       files.forEach(that.push.bind(that));
       cb();

lib/updateSubmodule.js

@@ -13,7 +13,7 @@ module.exports = function(opt, cb) {
 
   var cmd = 'git submodule update ' + opt.args;
   return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
-    if (err && cb) cb(err);
+    if (err && cb) return cb(err);
     if (!opt.quiet) gutil.log(stdout, stderr);
     if (cb) cb();
   });