Skip to content

Callback called twice #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ofavre opened this issue Jun 19, 2017 · 1 comment
Closed

Callback called twice #166

ofavre opened this issue Jun 19, 2017 · 1 comment

Comments

@ofavre
Copy link

ofavre commented Jun 19, 2017

It appears that some commands (I only checked addRemote) miss the return keyword when calling cb(err) on error conditions.

E.g.: https://github.com/stevelacy/gulp-git/blob/master/lib/addRemote.js#L24
@stephenlacy
Copy link
Owner

Thanks for reporting! dont know how I missed them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofavre @stephenlacy