Skip to content

Avoid brittle version parsing #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephrdev merged 1 commit into from
Jan 3, 2022
Merged

Avoid brittle version parsing #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
from unittest.mock import Mock

import pytest

from pytest_isort import FileIgnorer, IsortError, IsortItem


pytest_plugins = ('pytester',)


def get_pytest_version():
return tuple(map(int, pytest.__version__.split('.')))


def test_version():
import pytest_isort

Expand Down Expand Up @@ -189,10 +183,10 @@ class TestParent:
parent = TestParent()
path = testdir.tmpdir

if get_pytest_version()[0] < 5:
test_obj = IsortItem(path, parent)
else:
if hasattr(IsortItem, "from_parent"):
test_obj = IsortItem.from_parent(parent, fspath=path)
else:
test_obj = IsortItem(path, parent)

assert test_obj.name == path.basename
assert test_obj.parent == parent
Expand Down