Skip to content

Dyn comp invert #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Dyn comp invert #217

wants to merge 2 commits into from

Conversation

usbalbin
Copy link
Member

@usbalbin usbalbin commented Jul 6, 2025

From what I can tell there is nothing preventing us from changing the polarity of the comparator on the fly

@burrbull
Copy link
Member

burrbull commented Jul 6, 2025

It is better to use Polarity enum here instead of bool.

@usbalbin
Copy link
Member Author

usbalbin commented Jul 7, 2025

It is better to use Polarity enum here instead of bool.

Something like this e368fd8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usbalbin @burrbull