Skip to content

Conversation

NandoBongers
Copy link
Contributor

No description provided.

@mgottschlag
Copy link
Contributor

mgottschlag commented Nov 11, 2021

I believe this is wrong - the function does what the existing function into_alternate() is supposed to do. However, maybe I am overlooking something.

In any case, the modification to OTYPER has to be present in into_alternate() as well, because that function must not produce a open-drain pin if the same pin was previously used with into_alternate_open_drain().

If I am overlooking something, please explain what you had in mind with this PR. :)

EDIT: What I want to say is that your new function should be renamed into_alternate() and the old into_alternate() should be removed, essentially.

Renamed (into_alternate -> into_alternate_open_drain) and (into_alternate_push_pull -> into_alternate)
@NandoBongers
Copy link
Contributor Author

Hello @mgottschlag I renamed the functions as you suggested in my latest commit.

@luctius
Copy link
Collaborator

luctius commented Nov 15, 2021

I see no further issues with this commit.

Edit: could you run a cargo clippy & cargo fmt

@luctius luctius merged commit 45a7fc6 into stm32-rs:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants