Fixed delay to use AHB clock / 8 instead of CORE clk #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed working - also see: https://stackoverflow.com/questions/64172446/systick-timer-on-cortex-m4-what-is-its-prescaler |
|
Awesome, thanks! |
no111u3
pushed a commit
that referenced
this pull request
Dec 16, 2023
* Ci2 (#6) * Add g491 and 4a1 to ci, check examples, check with different feature sets * Add todo * Remove unused feature embedded-can-03 * Remove feature unstable-defmt from ci * Add clippy to ci * Fix warning * g91 and 4a1 support does not seem quite ready yet * Fix CI errors for flash example * Deny warnings * Fix more warnings * Fix warnings about empty loops * Fix more warnings related to itm or semihosting * Make itm use log::info as println to avoid logger arg * CI - Always enable some way to print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed delays where off by a factor 8. This was because the delay function calculated it's time based off the core clock. The cortex system timer is actually connected to AHB clock with a prescaler of /8.