Skip to content
This repository was archived by the owner on Jun 29, 2025. It is now read-only.

Conversation

NoorChasib
Copy link

@NoorChasib NoorChasib commented Apr 9, 2025

Description:

This PR enhances UI clarity by adding descriptive text labels to header icons and implementing tooltips for the main action icon buttons.

Motivation:

The goal is to improve usability and reduce potential confusion for all users. Explicit text labels in the header section make the function of those elements immediately clear. For the main action buttons (like Info, Undo, etc.), tooltips were added to clarify icon function upon hover, providing necessary context without permanently adding text to that potentially dense button area.

Changes:

  • Added descriptive text labels next to icons in the header section.
  • Implemented descriptive tooltips for main action icon buttons (Info, Undo, Download, Copy, etc.). (Changed from original plan of adding text labels here).
  • Included corresponding translations for the new header labels and action button tooltip text.
  • Code has been formatted using npm run format.

Visuals:

Before:

Screenshot 2025-04-08 at 5 38 45 PM2 Screenshot 2025-04-08 at 5 59 52 PM

After:

Screenshot 2025-04-10 at 9 32 09 PM Screenshot 2025-04-10 at 9 31 49 PM

@stonith404
Copy link
Owner

Thanks for your contribution :)

I would suggest to use tooltips instead of adding the text directly to the buttons. This would keep the UI compact but still describe each action for new users.

@NoorChasib
Copy link
Author

Hi @stonith404, thank you for the feedback!

That's a good point about keeping the UI compact. My initial reason for adding text directly was for mobile users, since tooltips aren't really a thing there. But if you think tooltips are the better overall approach, I'm happy to switch to that

@stonith404
Copy link
Owner

I just think especially on mobile the buttons just take too much space:
Screenshot 2025-04-10 at 19 05 05

But regarding mobile users, you could use the Mantine Tooltip which also supports touch devices.

@NoorChasib
Copy link
Author

@stonith404 I hadn't realized Mantine Tooltip was also available on mobile. Since that's the case, I'll adjust the PR and switch to using tooltips!

@NoorChasib
Copy link
Author

@stonith404 Please take a look over, when you get a chance!

Copy link
Owner

@stonith404 stonith404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response. Here are some things I would recommend to change.

<ActionIcon>
<Avatar size={28} />
</ActionIcon>
<Button
Copy link
Owner

@stonith404 stonith404 Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-23 at 09 56 51

I think this looks a bit inconsistent. I would keep the icon buttons but add a tooltip.

@@ -39,7 +39,8 @@ const DownloadAllButton = ({ shareId }: { shareId: string }) => {

return (
<Button
variant="outline"
variant="light"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the download buttons purple, because that's the primary color.
Screenshot 2025-04-23 at 10 05 46

<ActionIcon color="orange" variant="light" size={25}>
<TbEdit />
</ActionIcon>
<Tooltip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a component that wraps Tooltip with its common properties? For example the position, multiline and events are the same for every tooltip.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants