Skip to content

feat: drop Sentry #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: drop Sentry #7

merged 1 commit into from
Oct 5, 2023

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Oct 5, 2023

@P0lip P0lip self-assigned this Oct 5, 2023
<Component error={props.error} componentStack={props.componentStack} tryRecovering={props.resetError} />
);
};
export class ErrorBoundary<P extends object = {}> extends React.PureComponent<

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLASS COMPONENTS??? That brings me back. You know they don't even teach those in code bootcamps anymore. 🤣

Copy link
Contributor Author

@P0lip P0lip Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, there's no error hook 😆 if you need an error boundary, you're supposed to use a class component

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22B

Copy link

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure whatev :)

@P0lip P0lip marked this pull request as ready for review October 5, 2023 21:29
@P0lip P0lip merged commit e63e982 into master Oct 5, 2023
@P0lip P0lip deleted the feat/drop-sentry branch October 5, 2023 21:30
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants