fix: remove go binaries dependency #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove go binaries dependency
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on externally hosted Go binaries by building the node-prune binary from source using a dedicated Go build stage.
- Introduces a new build stage (using golang:1.18) to install node-prune from source.
- Removes the previous dependency on downloading the binary via curl.
| FROM golang:1.18 as nodeprune | ||
|
|
||
| # Build node-prune from source | ||
| RUN go install github.com/tj/node-prune@latest |
There was a problem hiding this comment.
It's recommended to specify a fixed version of node-prune instead of using '@latest' to ensure reproducible builds.
Suggested change
| RUN go install github.com/tj/node-prune@latest | |
| RUN go install github.com/tj/node-prune@v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove go binaries dependency