ci: run tests on all versions of Node.js supported by this package#2955
ci: run tests on all versions of Node.js supported by this package#2955gameroman wants to merge 1 commit into
Conversation
slegarraga
left a comment
slegarraga
left a comment
There was a problem hiding this comment.
CI matrix expansion makes sense. Quick check: Spectral package.json engines still lists minimum Node — if 16.x is below supported range, matrix will fail on purpose (good) or should be dropped. Otherwise LGTM from a contributor perspective.
slegarraga
left a comment
slegarraga
left a comment
There was a problem hiding this comment.
Node matrix CI is valuable here — one note: if the matrix explodes wall-clock on PRs, consider fail-fast: false only on release branches or cap to LTS + current.
Otherwise supportive of broader Node coverage aligned with engines in package.json.
slegarraga
left a comment
slegarraga
left a comment
There was a problem hiding this comment.
Aligns CI with the Node versions declared in `engines` — good coverage expansion.
One thought for maintainers: if wall-clock on PRs becomes an issue, consider pinning the matrix to LTS + current rather than every supported line. Otherwise looks good to me.
2 participants
No description provided.