feat: make time bounds validation configurable #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
alanshaw
approved these changes
Nov 3, 2025
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
👌 It's not what I expected, but I like it.
FWIW I was thinking of effectively configuring "now" for the validation...
Member
Author
|
oh, that would've worked too, and maybe would've been more ergonomic. In the defence of this approach I'd say that it's so flexible that it can be used today, while right now it's impossible to know what "now" is, unfortunately. But I like the idea and we might consider doing it that way if things change in the future. |
This was referenced Nov 3, 2025
volmedo
added a commit
to storacha/indexing-service
that referenced
this pull request
Nov 3, 2025
storacha/go-ucanto#78 in go-ucanto changes the signature of `validator.NewClaimContext` and `validator.NewValidationContext`. This is a breaking API change that impacts the indexing-service, so I proactively upgraded to the latest version and adapted existing code to the new API.
volmedo
added a commit
to storacha/piri
that referenced
this pull request
Nov 3, 2025
storacha/go-ucanto#78 in go-ucanto changes the signature of `validator.NewClaimContext` and `validator.NewValidationContext`. This is a breaking API change that impacts piri, so I proactively updated to the latest version and adapted existing code to the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expiration and Not Valid Before are useful when validating an invocation as part of deciding whether it should be executed. However, if we just want to check the validity of a given delegation chain that happened in the past, we don't care about time bounds.
These changes allow passing a custom time bounds validation function to decide how expiration and not valid before are validated.