Skip to content

Conversation

@alanshaw
Copy link
Member

@alanshaw alanshaw commented Nov 20, 2025

They were not being exported at all 😢

@alanshaw alanshaw requested a review from a team November 20, 2025 16:57
@alanshaw alanshaw requested a review from volmedo as a code owner November 20, 2025 16:57
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/receipt/receipt.go 75.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
core/receipt/receipt.go 65.18% <75.00%> (+0.60%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@volmedo volmedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no wonder they were not there, great catch

Copy link
Member

@Peeja Peeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanshaw alanshaw merged commit 02657eb into main Nov 20, 2025
2 checks passed
@alanshaw alanshaw deleted the ash/fix/export-fx-from-receipt branch November 20, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants