feat(trait): Validate for TrimmedNonEmptyString on regex argument
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng()` and `string()` methods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
=========================================
Coverage 93.88% 93.88%
Complexity 461 461
=========================================
Files 72 72
Lines 1620 1620
=========================================
Hits 1521 1521
Misses 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
silasjoisten
changed the title
nullOrString() and string() methodsTrimmedNonEmptyString on regex argument
silasjoisten
requested changes
Jul 18, 2025
OskarStark
reviewed
Jul 18, 2025
OskarStark
reviewed
Jul 18, 2025
OskarStark
approved these changes
Jul 18, 2025
Collaborator
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Good to merge after my comments
silasjoisten
approved these changes
Jul 18, 2025
Collaborator
|
Thanks @KristianH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows
string()&nullOrString()#59